Re: PATCH: numerous warnings from gnulib header files.

[Eric Blake]

On 02/06/2013 11:14 PM, Paul Eggert wrote:
> In <http://lists.gnu.org/archive/html/bug-gnulib/2013-02/msg00019.html>
> on 02/06/2013 12:13 AM, John Darrington wrote:
> 
>> ./SOURCE/gl/xalloc.h:176: error: no previous prototype for 'x2nrealloc'
> 
> I looked into this, and apparently it's a bug in GCC 4.4.5.
> The bug causes GCC to generate a bogus warning if one
> compiles with '-Wmissing-prototypes' and if a program
> contains an inline function that is not static.
> 
> Gnulib's general rule is to cater to GCC non-default compiler warnings
> only for the latest stable version of GCC, since older GCCs are
> fairly buggy in this area, and it's too much hassle to try
> to pacify them all.

Indeed, at least libvirt and coreutils are both using conditional
warnings, where certain warnings are only turned on for new-enough gcc.
 Maybe I should revisit the manywarnings module to hoist that logic up
into gnulib, instead of making each downstream project reinvent it.  The
question has come up in the past, though:
https://lists.gnu.org/archive/html/bug-gnulib/2012-12/msg00006.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature