bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs


From: Roland McGrath
Subject: Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs
Date: Thu, 7 Feb 2013 16:51:53 -0800 (PST)

> Roland McGrath <address@hidden> wrote:
> > That looks fine.  
> > 
> > >   * sysdeps/unix/sysv/linux/fstatvfs.c (fstatvfs):
> > >   Pass fd to __internal_statvfs instead of calling fstat64.
> > >   * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64):
> > >   Pass fd to __internal_statvfs64 instead of calling fstat64.
> > 
> > In a case like this, it's usual practice to write just "Likewise."
> > for the second one.  But that's not mandatory.
> 
> Ah, I considered "Likewise." but figured maybe the difference between
> "__internal_statvfs64" and "__internal_statvfs" might be significant
> (even though it's really the same function)

Oh, I didn't notice they weren't identical.  You're right that it shouldn't
use plain "Likewise." then.  But you could write:

        * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64):
        Likewise for __internal_statvfs64.

> I'm not fan of signing into websites or filling out <form> elements,
> so I am hoping to avoid that.  I haven't looked too closely at BZ,
> maybe there's an email/command-line interface like Debian BTS?

Not that I'm aware of, though perhaps there is some way.  
Using bugzilla is a prerequisite for participating in glibc development.

> > Do you have copyright papers on file with the FSF?  I don't see a record
> > for you.
> 
> No.  I consider this a trivial change, so I hope I don't have to.

The FSF guidelines don't classify it that way, because trivialness for
copyright purposes is about number of lines more than it's about conceptual
complexity.  If you are really averse to the paperwork, someone with papers
can reimplement the change.


Thanks,
Roland



reply via email to

[Prev in Thread] Current Thread [Next in Thread]