Re: [PATCH] test-open: avoid compilation error with -D_FORTIFY_SOURCE=2

[Eric Blake]

On 06/20/2013 09:45 PM, Daiki Ueno wrote:
> I got the following error when compiling test-open.c with
> -D_FORTIFY_SOURCE=2.
> 
>   $ gcc -DHAVE_CONFIG_H -I.  -DGNULIB_STRICT_CHECKING=1 -I. -I. -I.. -I./.. 
> -I../gllib -I./../gllib   -Wall -O1 -D_FORTIFY_SOURCE=2 -g -MT test-open.o 
> -MD -MP -MF .deps/test-open.Tpo -c -o test-open.o test-open.c
>   In file included from /usr/include/fcntl.h:296:0,
>                    from ../gllib/fcntl.h:61,
>                    from test-open.c:21:
>   test-open.h: In function 'main':
>   /usr/include/bits/fcntl2.h:41:1: error: inlining failed in call to 
> always_inline 'open': indirect function call with a yet undetermined callee
>    open (const char *__path, int __oflag, ...)
>    ^
> 
> It seems that open cannot be directly passed to test_open as a function
> pointer, since it is marked as always_inline.  I'm attaching a patch.

Just noticing this thread, and that no one ever seemed to reply.  Has
this issue been fixed in the meantime by Paul's improvements to inline
handling?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature