Re: [PATCH] Added a module stringops that provides STREQ and STRNEQ

[Jim Meyering]

On Wed, May 21, 2014 at 9:54 PM, Paul Eggert <address@hidden> wrote:
> Kieran Colford wrote:
>>
>> I deliberately chose to use it as a macro and call it this because that
>> is how it is done everywhere else in gnulib.
>
>
> Sure, but let's take this opportunity to do a better API, while we're making
> a module for it.  So my suggestion would be to replace STREQ with streq
> uniformly elsewhere, after the stringops module is added.
>
> I think Jim Meyering is the main reason Gnulib uses STREQ so much, so I'd
> like his opinion.  Jim, is it OK if we make the changes described in
> <http://lists.gnu.org/archive/html/bug-gnulib/2014-05/msg00040.html> when
> creating a module that implements a STREQ-like operation?

Hi Paul,

What about the conflict with modules/streq?
There are over 300 uses of STREQ in gnulib and coreutils.
Are you suggesting to change all of those?

I confess I'm quite used to STREQ, and while I definitely do
prefer inline functions to macros, I see little harm in ensconcing
the STREQ/STRNEQ macros in a gnulib module. I've missed
precisely this proposed new module several times,
over the years.