bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: test-getlogin false failure in non login shells


From: Pádraig Brady
Subject: Re: test-getlogin false failure in non login shells
Date: Thu, 22 May 2014 17:47:30 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 05/22/2014 05:40 PM, Eric Blake wrote:
>>        /* getlogin_r() fails when stdin is not connected to a tty.  */
>> -      ASSERT (err == ENOTTY
>> +      ASSERT (errno == ENOTTY
>>                || errno == EINVAL /* seen on Linux/SPARC */
>>                || errno == ENXIO
> 
> So this should actually be checking 'err', not 'errno', for all three
> instances.

Ok I was reading third party man pages rather than the spec.
I'll fix in a follow up (and follow my own advice and
delay pushing patches a while to allow for review).

thanks!
Pádraig.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]