error.c triggers -Wformat-extra-args

[Daniel E. Macks]

Building gettext-0.19.1, which embeds copies of gnulib, on OS X 10.8,
which uses the clang compiler (via XCode-5.1), gives:

clang -DHAVE_CONFIG_H -DEXEEXT=\"\" -I. -I..  -I../intl -I../intl 
-DDEPENDS_ON_LIBICONV=1 -DDEPENDS_ON_LIBINTL=1  -I/sw/include  -Os -c -o 
error.o error.c
error.c:381:12: warning: data argument not used by format string 
[-Wformat-extra-args]
           file_name, line_number);
           ^

The same construct is still present in error.c in gnulib git [1]:

#if _LIBC
  __fxprintf (NULL, file_name != NULL ? "%s:%d: " : " ",
              file_name, line_number);
#else
  fprintf (stderr, file_name != NULL ? "%s:%d: " : " ",
           file_name, line_number);
#endif

In the case where file_name==NULL, the format-string is " " but
file_name and line_number are still passed. This may not be a
functional error [2], but it's an easy-to-clear warning, which will
help downstream users who build with -Werror or generally want cleaner
and quieter builds especially of code they don't control. Just have
whole alternative fprintf() with appropriate parameters in a
conditional if/else block rather than just conditional on the
format-string. Something like:

  if (file_name != NULL)
    fprintf (stderr, "%s:%d: ", file_name, line_number)
  else
    fprintf (stderr, " ");




[1] http://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/error.c
[2] 
http://stackoverflow.com/questions/3578970/passing-too-many-arguments-to-printf


dan

-- 
Daniel Macks
address@hidden