Re: [PATCH] Add missing include of windows.h in nl_langinfo.c

[Eric Blake]

On 07/09/2014 05:13 AM, Pavel Hrdina wrote:
> The commit fcfce839 improved localization of names for week days
> and months, but the author forget to include windows.h in order
> to use 'GetACP ()'. Without this header file build using mingw
> fails with this error message:
> 
> ../../../gnulib/lib/nl_langinfo.c: In function 'ctype_codeset':
> ../../../gnulib/lib/nl_langinfo.c:76:5: warning: implicit declaration of
> function 'GetACP' [-Wimplicit-function-declaration]
>      sprintf (buf + 2, "%u", GetACP ());
>      ^
> In file included from
> /usr/i686-w64-mingw32/sys-root/mingw/include/windows.h:73:0,
>                  from ../../../gnulib/lib/nl_langinfo.c:149:
> /usr/i686-w64-mingw32/sys-root/mingw/include/winnls.h: At top level:
> /usr/i686-w64-mingw32/sys-root/mingw/include/winnls.h:653:64: error:
> conflicting types for 'GetACP'
>    WINBASEAPI UINT WINAPI GetACP(void);
>                                                                 ^
> ../../../gnulib/lib/nl_langinfo.c:76:29: note: previous implicit
> declaration of 'GetACP' was here
>      sprintf (buf + 2, "%u", GetACP ());
>                              ^
> 
> Signed-off-by: Pavel Hrdina <address@hidden>
> ---
>  lib/nl_langinfo.c | 1 +
>  1 file changed, 1 insertion(+)

ACK, fix pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature