bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

compilation warning in error.c


From: Werner LEMBERG
Subject: compilation warning in error.c
Date: Wed, 05 Nov 2014 08:56:40 +0100 (CET)

[v0.1-248-gc564172]

A user reported the following warning:

    CC       error.lo
  error.c:386:12: warning: data argument not used by format string
  [-Wformat-extra-args]
             file_name, line_number);
             ^

Below is a trivial patch that fixes this.


    Werner


======================================================================


2014-11-05  Werner Lemberg  <address@hidden>

        error: fix warning message

        * lib/error.c (error_at_line): Always use correct number of
        arguments for format string.

diff --git a/lib/error.c b/lib/error.c
index 18ff5db..d83cfb2 100644
--- a/lib/error.c
+++ b/lib/error.c
@@ -379,11 +379,15 @@ error_at_line (int status, int errnum, const char 
*file_name,
     }
 
 #if _LIBC
-  __fxprintf (NULL, file_name != NULL ? "%s:%d: " : " ",
-              file_name, line_number);
+  if (file_name != NULL)
+    __fxprintf (NULL, "%s:%d: ", file_name, line_number);
+  else
+    __fxprintf (NULL, " ");
 #else
-  fprintf (stderr, file_name != NULL ? "%s:%d: " : " ",
-           file_name, line_number);
+  if (file_name != NULL)
+    fprintf (stderr, "%s:%d: ", file_name, line_number);
+  else
+    fprintf (stderr, " ");
 #endif
 
   va_start (args, message);



reply via email to

[Prev in Thread] Current Thread [Next in Thread]