Re: [bug-libunistring] [PATCH] uniname/uniname-tests: skip if system's libunistring is used

[Daiki Ueno]

Pádraig Brady <address@hidden> writes:

>> This prefers system's libunistring to the corresponding Gnulib module.
>> I think Gnulib tests should rather prefer Gnulib modules.  Does anyone
>> know what's the rationale behind this?
>
> The tests generally test the combination of system and gnulib bits.
> Ideally the test would be split based on features per libunistring version,
> but if that's awkward then skipping is fine.

Ah, I see.  Thanks for the explanation.  I'm attaching a patch in that
direction (i.e. skipping the test at the Makefile.am level, based on
whether the Gnulib module is compiled).

Regards,
--
Daiki Ueno

>From 72d21c164fe1ab24b508f770f436d3ceacbefeec Mon Sep 17 00:00:00 2001
From: Daiki Ueno <address@hidden>
Date: Thu, 27 Nov 2014 18:46:43 +0900
Subject: [PATCH] uniname/uniname-tests: skip if system's libunistring is used

* modules/uniname/uniname-tests (Makefile.am): Skip test if
uniname/uniname module is not compiled.
---
 ChangeLog                     | 6 ++++++
 modules/uniname/uniname-tests | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index e051495..92bcd77 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2014-11-27  Daiki Ueno  <address@hidden>
+
+       uniname/uniname-tests: skip if system's libunistring is used
+       * modules/uniname/uniname-tests (Makefile.am): Skip test if
+       uniname/uniname module is not compiled.
+
 2014-11-22  Daiki Ueno  <address@hidden>
 
        pipe-filter-gi, pipe-filter-ii: port to AIX
diff --git a/modules/uniname/uniname-tests b/modules/uniname/uniname-tests
index a18f942..305e6a1 100644
--- a/modules/uniname/uniname-tests
+++ b/modules/uniname/uniname-tests
@@ -10,8 +10,10 @@ progname
 configure.ac:
 
 Makefile.am:
+if LIBUNISTRING_COMPILE_UNINAME_UNINAME
 TESTS += uniname/test-uninames.sh
 check_PROGRAMS += test-uninames
 test_uninames_SOURCES = uniname/test-uninames.c
 test_uninames_LDADD = $(LDADD) $(LIBUNISTRING) @LIBINTL@
+endif
 
-- 
2.1.0