[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/21] Workaround for dirfd() on OS/2 kLIBC
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 18/21] Workaround for dirfd() on OS/2 kLIBC |
|
Date: |
Tue, 02 Dec 2014 08:11:52 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 12/02/2014 06:17 AM, KO Myung-Hun wrote:
> Hi/2.
>
> Paul Eggert wrote:
>> KO Myung-Hun wrote:
>>> * lib/fts.c (fts_build): Do not check dir_fd on OS/2 kLIBC.
>>
>> I'm afraid this change needs more explanation. If the problem is that
>> dirfd returns -2, the earlier part of fts_build will return when that
>> happens, so that problem cannot be fixed by the patch that you sent.
>>
>
> First of all, sorry. I've misread codes. Essential problem is that kLIBC
> dup() does not work on a directory fd. So this patch tries to use a path
> instead of fd.
Then we should probably try to figure out a workaround for broken dup()
first.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature