[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libvirt] [PATCH] Define __USE_MINGW_ANSI_STDIO in config.h
|
From: |
Eric Blake |
|
Subject: |
Re: [libvirt] [PATCH] Define __USE_MINGW_ANSI_STDIO in config.h |
|
Date: |
Mon, 08 Dec 2014 13:32:44 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/02/2014 06:50 AM, Pádraig Brady wrote:
>>> It could perhaps be argued that gnulib's 'asprintf'
>>> could be defining __USE_MINGW_ANSI_STDIO for us ?
>>
>> Yes, gnulib should be taking advantage of this new mingw development.
>
> I independently noticed this mingw feature when looking at the portability
> of gnulib's ftoastr to mingw. I agree that gnulib should define this.
> Note ftoastr doesn't depend on any of the gnulib printf modules
> as that was thought to be overkill for the portability provided,
> so I'm not sure where to put this define. In the attached I added
> it to the extensions module and depended on that from both ftoastr and stdio.
>
I went ahead and pushed this patch. Thanks for reviving this topic.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature