Re: [PATCH v3] bootstrap: Allow perl modules in $buildreq

[Eric Blake]

On 12/08/2014 05:19 AM, Martin Kletzander wrote:
> With this patch it is possible to put e.g. "perl::XML:XPath -" in
> $buildreq in bootstrap.conf which will cause a check for perl module
> XML::XPath using:
> 
>   perl -m"XML::XPath" -e 'exit 0' >/dev/null 2>&1
> 
> If this fails due to any other error then XML::XPath missing, it is left

s/then/than/

> on the user to fix up his/hers bootstrap.conf.  One of the examples

s/hers/her/

> might be perl itself missing, which should be in $buildreq and precede
> any perl::Module specifications.  Versioning of perl modules is not
> supported.
> 
> Signed-off-by: Martin Kletzander <address@hidden>
> ---

Looks good to me; I've gone ahead and pushed it, after adding a
ChangeLog entry (the "tiny change" notation I added there covers the
fact that this contribution does not need copyright papers from you,
whether or not it is considered that Red Hat's blanket assignment would
apply to your submission).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature