Re: locale test failures on illumos

[Pádraig Brady]

On 19/01/15 14:01, Pádraig Brady wrote:
> On 15/01/15 18:05, Alexander Pyhalov wrote:
>> Hello.
> 
>> test-locale.c. It assumes that LC_GLOBAL_LOCALE is a constant.
>> On illumos it's a function, so compilation fails. Fix is here:
> https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/coreutils/patches/gnulib-tests_test-locale.c.patch
> 
> This looks good, though it would be preferable to combine with a fix for...
> 
>> [test-getlogin] uses gl_locale_name_thread_unsafe, which simply doesn't know 
>> about
>> illumos/Solaris and returns NULL, so the test fails.
> 
> Does querylocale() exist for __sun ?
> Perhaps it's just a matter of adding __sun to the elif define
> in gl_locale_name_thread_unsafe() ?

It seems this is hitting recently as solaris 12 added uselocale()
which triggers this path.  Rich Burridge tells me that the function
used on solaris 12 is in fact getlocalename_l(), which
may work for Illumos also?
Rich is there really no header for this function?
I've called the non double underscore name which I presume is OK.
Also I just used the __sun define as done throughout gnulib.

The attached two patches should hopefully fix the issue
on both illumos and solaris 12.  I've no access to
either to test unfortunately.

thanks,
Pádraig.

sun-localename.patch
Description: Text Data