Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

[Eric Blake]

On 05/26/2015 04:09 PM, Assaf Gordon wrote:
> Hello Eric,
> 
> Thanks for your quick reply and fix.
> 
> I've found one more issue which I'm not sure how to solve - interplay
> between gcc/mingw/inttypes/gnulib: The format string to "error()".
> 
> In theory (if I understand correctly), printf() and error() should
> accept the same format specifiers,
> thus should both work with PRI.MAX.
> 
> However,
> after having the PRIdMAX changed back to 'lld', using it in 'error()'
> causes a warning under mingw:

Ah. Gnulib needs to mark error() as being __gnu_printf__, not __printf__.


> 
> Which brings the question: will the compiled executable work? (it
> compiles and I get an 'exe' file, but don't have a way to test it ATM).

You don't have wine set up to run trivial .exe files on Linux?  At any
rate, yes, it will work (the warning is bogus), but in the meantime,
I'll apply a patch to gnulib's error.h to silence the warning.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature