Re: [PATCH] maint: add a script to list libunistring modules

[Jim Meyering]

On Fri, Jun 19, 2015 at 6:50 PM, Daiki Ueno <address@hidden> wrote:
> Daiki Ueno <address@hidden> writes:
>
>>>         The modules are listed by a script that does:
>>>         - for each file listed by: git show --oneline --name-only 705f4efc
>>>           - deduce the containing modules, based on "Files:"
>>>         - deduce the modules which depend on the containing modules, based
>>>           on "Depends-on:"
>>>
>>> It's tempting to automate those steps.  Is it okay to add some scripts
>>> for that to Gnulib?
>>
>> So here it is.  As noted in the comment, it's often too slow.

Your script looks fine. The only change I would make would be
to use $(...) in place of `...`, but that is mainly stylistic.
Nice work!

> Actually, it would be trivial if gnulib-tool had support for:
>
> - listing reverse dependencies: --extract-reverse-dependencies module
> - listing containing module, like rpm -qf: --extract-containing-modules file
> - recursive query for --extract-dependencies, etc: --recursive
>
> Perhaps these features might be generally useful, but I doubt that they
> are acceptable since gnulib-tool seems already too complex to
> accommodate such new options (might be a good addition to
> python-gnulib).

That seems like the right conclusion.