Re: bug#20923: mgetgroups.c vs getgrouplist warning on OS X

[Jim Meyering]

On Mon, Jun 29, 2015 at 7:19 PM, Paul Eggert <address@hidden> wrote:
> Jim Meyering wrote:
>>
>> Darn it. I see that I mistakenly pushed one of your patches
>> when I pushed the linkat.m4 fix, Paul. Sorry about that.
>> Happy to revert, if you'd like that. Let me know.
>
> No problem.  I installed the attached further patch; does it fix things for
> you?  If we can't get this to work I can revert the whole thing.

Thanks.

I adjusted via the attached patch (the declaration
of getgrouplist is in <unistd.h>, and the "then"-block
should use gid_t), and tested: there was not even a
warning for the test program emitted by the "then"-block,
so same result as before:

  lib/mgetgroups.c: In function 'mgetgroups':
  lib/mgetgroups.c:70:32: error: pointer targets in passing argument 3
of 'getgrouplist' differ in signedness [-Werror=pointer-sign]
   #  define getgrouplist_gids(g) (g)
                                  ^

mgetgroups.m4.patch
Description: Binary data