[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnul
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnul |
|
Date: |
Sun, 18 Oct 2015 14:01:28 -0700 |
On Sun, Oct 18, 2015 at 10:28 AM, Paul Eggert <address@hidden> wrote:
> Jim Meyering wrote:
>>
>> Building coreutils configured with --enable-gcc-warnings and using
>> bleeding-edge gcc evoked a build failure due to the time_rz module.
>> The attached patch removes the warning/error-evoking test.
>
>
> This patch doesn't look right: if localtime_r fails, the original code
> returns NULL, but the revised code does not. I installed the attached
> further patch which fixes that, and which attempts to work around the
> compiler warning (though I can't easily test that).
Oh, good catch. Thank you. That too avoids the warning.