bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: problem in gperf makefile rules


From: Daiki Ueno
Subject: Re: problem in gperf makefile rules
Date: Sat, 19 Dec 2015 07:50:22 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Assaf Gordon <address@hidden> writes:

> I'm encountering some build errors during 'make' in projects using gnulib, 
> and I suspect it has something to do with this commit:
>
>    gperf: respect silent rules
>    
> http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=30f4290277444b1d4825a42c9a33f2c3c7fe310a
>
> The symptom I've found is that the GPERF/V_GPERF variables are expanded 
> multiple times (or incorrectly):
>
>     $ grep GPERF Makefile
>     GPERF = gperf
>     V_GPERF = lib/$(V_GPERF_$(V))
>     V_GPERF_ = lib/$(V_GPERF_$(AM_DEFAULT_VERBOSITY))
>     V_GPERF_0 = lib/@echo lib/"  lib/GPERF   lib/" lib/$@;

Sorry, I didn't realize that I need to adjust build-aux/prefix-gnulib-mk
for that change.  The attached patch should fix it.

Regards,
-- 
Daiki Ueno
>From 284866e96d4cbcf3ee82f7cf735c66cffd90b24c Mon Sep 17 00:00:00 2001
From: Daiki Ueno <address@hidden>
Date: Sat, 19 Dec 2015 07:42:27 +0900
Subject: [PATCH] non-recursive-gnulib-prefix-hack: preserve V_GPERF lines

* build-aux/prefix-gnulib-mk (prefix_assignment): Don't change the RHS
of 'V_GPERF.* = ' lines.  Reported by Assaf Gordon in:
https://lists.gnu.org/archive/html/bug-gnulib/2015-12/msg00015.html
---
 build-aux/prefix-gnulib-mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build-aux/prefix-gnulib-mk b/build-aux/prefix-gnulib-mk
index 8af2916..0ac81a8 100755
--- a/build-aux/prefix-gnulib-mk
+++ b/build-aux/prefix-gnulib-mk
@@ -91,7 +91,7 @@ sub prefix_assignment ($$)
 
   # Some variables are initialized by gnulib.mk, and we don't want
   # that.  Change '=' to '+='.
-  if ($lhs_and_assign_op =~ /^GPERF =$/)
+  if ($lhs_and_assign_op =~ /^(GPERF|V_GPERF.*) =$/)
     {
       # Do not change the RHS, which specifies the GPERF program.
     }
-- 
2.6.4


reply via email to

[Prev in Thread] Current Thread [Next in Thread]