bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] intprops, mktime, strtol: assume two's complement


From: Paul Eggert
Subject: Re: [PATCH] intprops, mktime, strtol: assume two's complement
Date: Wed, 13 Apr 2016 10:56:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1

On 04/13/2016 07:30 AM, Eric Blake wrote:
wouldn't it be nicer to
force a compiler error in the (unlikely) case that TYPE_TWOS_COMPLEMENT
doesn't hold?

Thanks, good suggestion. I installed the attached patch. It's part 1 of a pair; I'll follow up with a patch to mktime.c that uses intprops.h etc. instead of attempting to do overflow checking by hand.

Attachment: 0001-intprops-check-two-s-complement-assumption.patch
Description: Source code patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]