bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Make git-version-gen compatible with dash shell


From: Mosè Giordano
Subject: Re: Make git-version-gen compatible with dash shell
Date: Sun, 8 May 2016 20:48:51 +0200

2016-05-08 20:42 GMT+02:00 Paul Eggert <address@hidden>:
> Mosè Giordano wrote:
>> Without the patch I get a
>>
>>     shift: can't shift that many
>>
>> error.
>
> Thanks. It's preferable to get an error, since callers should not pass 
> --prefix
> without an argument operand. However, the shell script should not be relying 
> on
> undefined behavior to report the error. I installed the attached patch, which
> should fix that.

Thank you.  I spotted the error while testing Gnuastro build script,
indeed git-version-gen was called in this way:

    git-version-gen .tarball-version --prefix

I'm going to report the error to Gnuastro maintainer.

Bye,
Mosè



reply via email to

[Prev in Thread] Current Thread [Next in Thread]