[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] gettext-h: avoid undefined behavior
|
From: |
Daiki Ueno |
|
Subject: |
Re: [PATCH v2] gettext-h: avoid undefined behavior |
|
Date: |
Thu, 12 May 2016 16:34:09 +0900 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Bruno Haible <address@hidden> writes:
> While your patch is correct, I don't like that much code that
> - does free(NULL) in the main execution path of the code,
> - does computations such as (n == 1 ? msgid : msgid_plural)
> before they turn out to be needed.
> - assigns a variable in several places in a single execution
> path. (I prefer variables that are assigned exactly once.
> That makes the code clearer.)
>
> How about this patch instead? (Complete git change in attachment.)
Thanks, pushed it to master.
Regards,
--
Daiki Ueno