[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Re: Issue of 'gitlog-to-changelog' due to 'git rev-parse'
From: |
Stefan Vargyas |
Subject: |
Re: Re: Issue of 'gitlog-to-changelog' due to 'git rev-parse' |
Date: |
Mon, 4 Jul 2016 13:03:31 -0700 |
> Date: Mon, 4 Jul 2016 18:34:02 +0100
> From: Pdraig Brady <address@hidden>
> Subject: Re: Issue of 'gitlog-to-changelog' due to 'git rev-parse'
>
> ...
>
> thanks for the fix.
> I see that --git-dir can return relative or absolute results
> (if invoked in subdir of repo for example).
> Do we need special handling for returned absolute results?
>
> cheers,
> Pádraig
Pádraig,
Thank you for your response.
Indeed you raised a good point:
$ mkdir -vp /tmp/foo/bar
mkdir: created directory `/tmp/foo'
mkdir: created directory `/tmp/foo/bar'
$ (cd /tmp/foo && git init)
Initialized empty Git repository in /tmp/foo/.git/
$ ./git-dir /tmp/foo
target: /tmp/foo
from git: .git
from abs_path: /tmp/foo/.git
$ ./git-dir /tmp/foo/bar
target: /tmp/foo/bar
from git: /tmp/foo/.git
from abs_path: /tmp/foo/.git
$ alias git-dir="`pwd`/git-dir"
$ (cd /tmp && git-dir foo)
target: foo
from git: .git
from abs_path: /tmp/foo/.git
$ (cd /tmp && git-dir foo/bar)
target: foo/bar
from git: /tmp/foo/.git
from abs_path: /tmp/foo/.git
Therefore, I propose a new patch for you to scrutinize.
Stefan V.
gitlog-to-changelog-2.patch.gz
Description: Binary data
git-dir.gz
Description: Binary data