Re: bug#24256: new module for grep's DFA matcher

[Jim Meyering]

On Sat, Sep 10, 2016 at 10:59 AM, Jim Meyering <address@hidden> wrote:
> On Thu, Sep 8, 2016 at 10:27 PM, Jim Meyering <address@hidden> wrote:
>> On Wed, Aug 17, 2016 at 5:11 PM, Jim Meyering <address@hidden> wrote:
>>> On Wed, Aug 17, 2016 at 2:14 PM, Paul Eggert <address@hidden> wrote:
>>>> This all sounds good, thanks. Your attachment was a submodule diff
>>>> (basically, a pair of git commit IDs), so not much to review.
>>>
>>> Oops. Wrong working directory. Thanks.
>>> I've attached the real diff, this time.
>>>
>>>> I have some dfa.c-related changes pending. I assume it'll be OK for me to
>>>> commit them to grep as needed, and that when you make the switch you'll 
>>>> grab
>>>> the then-current version from grep. If you need me to get out of the water
>>>> around that time, please just let me know.
>>>
>>> As long as there are still soon-to-be-committed changes for grep's
>>> dfa.[ch], I'm happy to wait.
>>
>> I have sync'd the latest grep/dfa bits into my gnulib
>> dfa-module-adding patch, and updated the grep-side patch that makes
>> grep use that new module. Attached for anyone who cares to review.
>> If you're interested in trying it, you should first "cd" into grep's
>> gnulib directory and use "git am gnulib*.diff" to apply the first
>> patch there. Then "cd .. && git ci -m 'commit local gnulib+dfa change'
>> -a", then apply the grep patch and rerun the usual ./bootstrap &&
>> ./configure ... && make && make test
>
> I found/fixed a few nits in the gnulib diff, and changed a test
> dependency from progname to getprogname. I have pushed this to gnulib:

I have just now pushed these two commits to grep's repository, making
it use gnulib's new dfa module. The first just updates to latest
gnulib submodule. The second removes the subsumed files and grep's
references to them.

grep-use-gnulib-dfa-module.diff
Description: Text document