bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: quotearg test failures


From: Bruno Haible
Subject: Re: quotearg test failures
Date: Wed, 19 Oct 2016 01:50:55 +0200
User-agent: KMail/4.8.5 (Linux/3.8.0-44-generic; KDE/4.8.5; x86_64; ; )

Hi Padraig,

> In the attached I added a single extra orig_buffersize variable to
> control an extra read-only scan.

Thanks, it looks good.

The other recursive call to quotearg_buffer_restyled

  return quotearg_buffer_restyled (buffer, buffersize, arg, argsize,
                                   quoting_style,
                                   flags & ~QA_ELIDE_OUTER_QUOTES, NULL,
                                   left_quote, right_quote);

is also OK, because the code is careful not to make more than one
STORE (...) call per input byte if elide_outer_quotes is true. There are
enough occurrences of

              if (elide_outer_quotes)
                goto force_outer_quoting_style;

so that the string that was produced before this recursive call will
not be longer than the one produced by the recursive call. => All fine.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]