bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] dfa: addition of new state on demand


From: Jim Meyering
Subject: Re: [PATCH] dfa: addition of new state on demand
Date: Fri, 25 Nov 2016 11:52:09 -0800

On Fri, Nov 25, 2016 at 11:03 AM, Paul Eggert <address@hidden> wrote:
> Norihiro Tanaka wrote:
>>
>> Can anyone review this change?
>
>
> Thanks for doing all that, and sorry about the late review. I reviewed it,
> tweaked its commit message and propagated that into ChangeLog (the gnulib
> practice), and installed the result into gnulib, with two followup patches
> that I hope are self-explanatory. All three patches are attached. Please let
> us know of any problems you see with the result.
>
> CC'ing this to grep-devel since that's where the hardy band of dfa consumers
> hang out.

Thanks to both of you.
I confirmed that with those, grep still passes all of its tests, even
with ASAN (and hence leak detection) enabled.

Paul, I see one typo in your 2nd change's log: s/cdalls/calls/

  Omit unnecessary cdalls to zeroset.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]