bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug in do-release-commit-and-tag


From: Eric Blake
Subject: Re: bug in do-release-commit-and-tag
Date: Sat, 31 Dec 2016 08:23:59 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

On 12/31/2016 08:18 AM, Eric Blake wrote:
> I'm considering the use of do-release-commit-and-tag for releasing m4
> 1.4.18, but I tested it while in the middle of a git rebase, and got:
> 
> $ ./build-aux/do-release-commit-and-tag 1.4.18 stable
> ./build-aux/do-release-commit-and-tag: line 146: test: too many arguments
> do-release-commit-and-tag: not on branch (no branch, rebasing branch-1.4)
> 
> 
> The following is a rough patch that would avoid the improper use of
> test, but it still leaves a wonky error message.  I'm not sure if a
> better fix would be a change to the computation of the default value of
> $branch earlier in the file.  I guess that means I'm not even sure of
> the best way to use the script.
> 
> Suggestions?

As it is, I noticed (the hard way) that do-release-commit-and-tag
assumes that you are already using gitlog-to-changelog to generate a
ChangeLog (I guess that means I _first_ have to patch m4 to finally
catch up with what everyone else has been doing with generated
changelogs at release time).  But documenting that fact in the script,
and/or adding a module dependency, may make it more obvious.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]