[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: more systematic m4 quoting
|
From: |
Jim Meyering |
|
Subject: |
Re: more systematic m4 quoting |
|
Date: |
Tue, 11 Jul 2017 14:36:53 +0200 |
On Tue, Jul 11, 2017 at 1:57 PM, Bruno Haible <address@hidden> wrote:
> When going through all AC_RUN_IFELSE invocations, I noticed some places
> without systematic m4 quoting (like we used to do in the first years of
> autoconf) or misleading indentation.
>
> When people complain about the GNU Build System, one of the arguments is
> the steep learning curve of understanding a .m4 file which consists of
> a mix of 3 languages: m4 macros, autoconf macros, and shell scripts.
> The confusion is bigger when the various levels of m4 expansion are not
> properly delimited. Therefore I think systematic quoting is primarily
> good to clarify the boundaries of snippets in the 3 languages. Even in
> cases where we "know" that an additional m4 expansion will cause no harm.
>
>
> 2017-07-11 Bruno Haible <address@hidden>
>
> More systematic m4 quoting and indentation.
> * m4/chdir-long.m4 (gl_FUNC_CHDIR_LONG): Quote systematically.
> * m4/d-ino.m4 (gl_CHECK_TYPE_STRUCT_DIRENT_D_INO): Likewise.
> * m4/d-type.m4 (gl_CHECK_TYPE_STRUCT_DIRENT_D_TYPE): Likewise.
> * m4/dirfd.m4 (gl_FUNC_DIRFD): Likewise.
> * m4/host-os.m4 (gl_HOST_OS): Likewise.
> * m4/jm-winsz1.m4 (gl_HEADER_TIOCGWINSZ_IN_TERMIOS_H,
> gl_WINSIZE_IN_PTEM): Likewise.
> * m4/mbrtowc.m4 (AC_FUNC_MBRTOWC): Likewise.
> * m4/physmem.m4 (gl_SYS__SYSTEM_CONFIGURATION): Likewise.
> * m4/pselect.m4 (gl_FUNC_PSELECT): Likewise.
> * m4/fchownat.m4 (gl_FUNC_FCHOWNAT_DEREF_BUG): Quote systematically.
> Correct indentation.
> * m4/getcwd-abort-bug.m4 (gl_FUNC_GETCWD_ABORT_BUG): Likewise.
> * m4/getcwd-path-max.m4 (gl_FUNC_GETCWD_PATH_MAX): Likewise.
> * m4/jm-winsz2.m4 (gl_HEADER_TIOCGWINSZ_NEEDS_SYS_IOCTL): Likewise.
> * m4/rmdir-errno.m4 (gl_FUNC_RMDIR_NOTEMPTY): Likewise.
> * m4/tzset.m4 (gl_FUNC_TZSET_CLOBBER): Likewise.
> * m4/unlink-busy.m4 (gl_FUNC_UNLINK_BUSY_TEXT): Likewise.
I agree.
Thank you for all of that.