|
From: | Paul Eggert |
Subject: | Re: [PATCH] git-version-gen: Fix for tags containing '-' |
Date: | Sun, 6 Aug 2017 12:02:17 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Markus Armbruster wrote:
there's an additional problem my patch fails to address: # Change the first '-' to a '.', so version-comparing tools work properly. # Remove the "g" in git describe's output string, to save a byte. v=`echo "$v" | sed 's/-/./;s/\(.*\)-g/\1-/'`; Messes with '-' in tags. I think it should replace the first '-g' instead. What do you think?
Sorry, I'm not following. Could you give an example of the problem? Evidently the code is messing with the first "-" and the last "-g" deliberately.
[Prev in Thread] | Current Thread | [Next in Thread] |