bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: clang's Undefined Sanitizer


From: Bruno Haible
Subject: Re: clang's Undefined Sanitizer
Date: Thu, 24 Aug 2017 11:34:42 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-91-generic; KDE/5.18.0; x86_64; ; )

Hi Benno,

Paul Eggert writes:
> With that in mind I attempted to merge that patchset into 
> Gnulib by installing the attached.

This part of the patch:

@@ -190,11 +175,8 @@ convert_dirent (const struct dirent *source)
       struct readdir_result result = { NULL, };
       return result;
     }
-  else
-    {
-      struct readdir_result result = READDIR_RESULT_INITIALIZER (source);
-      return result;
-    }
+  struct readdir_result result = READDIR_RESULT_INITIALIZER (source);
+  return result;
 }
 
 #ifndef COMPILE_GLOB64
@@ -208,31 +190,11 @@ convert_dirent64 (const struct dirent64 *source)
       struct readdir_result result = { NULL, };
       return result;
     }
-  else
-    {
-      struct readdir_result result = READDIR_RESULT_INITIALIZER (source);
-      return result;
-    }
+  struct readdir_result result = READDIR_RESULT_INITIALIZER (source);
+  return result;
 }
 #endif
 

discards your change
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=e29357c8f445320cb3084352579fb2648cce4d0f

I haven't gotten any answer to my inquiries
https://lists.gnu.org/archive/html/bug-gnulib/2017-07/msg00009.html

Can you confirm that you can use a newer GCC on Haiku, and that therefore said
change was not actually needed?

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]