bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] wcwidth: check a macro version of wcwidth () as well


From: KO Myung-Hun
Subject: Re: [PATCH] wcwidth: check a macro version of wcwidth () as well
Date: Sat, 07 Oct 2017 20:09:29 +0900
User-agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2

Hi/2.

Bruno Haible wrote:
> Hi,
> 
> KO Myung-Hun wrote:
>>> With your patch, does the following command sequence pass its tests?
>>>
>>>   $ ./gnulib-tool --create-testdir --dir=testdir1 --single-configure 
>>> --with-c++-tests wcwidth
>>>   $ cd testdir1
>>>   $ ./configure
>>>   $ make
>>>   $ make check
>>>
>>
>> I attach test-suite.log.
> 
> Thanks. I'm glad to see that it passes the test-wchar-c++ test.
> 
>>>> +    gl_cv_func_wcwidth_macro,
>>>> ...
>>>> +       gl_cv_func_wcwidth_macro=yes,
>>>> +       gl_cv_func_wcwidth_macro=no)])
>>>
>>> In gnulib, for a long time, we use "quote all m4 macro arguments through 
>>> brackets"
>>> coding style. Just a matter of consistent coding style (that makes our 
>>> Autoconf
>>> macros halfway readable).
>>>
>>
>> Fixed. And I increased serial number by 1.
> 
> Thanks, I applied your patch, with the additional optimizations (below):
> 
> - Don't perform the "checking whether wcwidth is a macro" test when wcwidth
>   is already known to be a function (which is the case on the vast majority
>   of platforms).
> - Simplify 'test EXPR1 || test EXPR2' to 'test EXPR1 -o EXPR2'.
> 
> Hope I didn't introduce any bugs through this.
> 

It works well. Thanks.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]