[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] wcwidth: check a macro version of wcwidth () as well
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] wcwidth: check a macro version of wcwidth () as well |
|
Date: |
Mon, 9 Oct 2017 14:29:10 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/07/2017 02:23 AM, Bruno Haible wrote:
> Thanks, I applied your patch, with the additional optimizations (below):
>
> - Simplify 'test EXPR1 || test EXPR2' to 'test EXPR1 -o EXPR2'.
No, that is a pessimization. POSIX explicitly states that use of -a or
-o with test is prone to obscure breakage, and should not be treated as
portable.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [PATCH] wcwidth: check a macro version of wcwidth () as well, KO Myung-Hun, 2017/10/06
- Re: [PATCH] wcwidth: check a macro version of wcwidth () as well, Bruno Haible, 2017/10/06
- Re: [PATCH] wcwidth: check a macro version of wcwidth () as well, KO Myung-Hun, 2017/10/07
- Re: test-init.sh failure on OS/2, Bruno Haible, 2017/10/07
- Re: test-init.sh failure on OS/2, KO Myung-Hun, 2017/10/07
- Re: test-init.sh failure on OS/2, Bruno Haible, 2017/10/07
- Re: test-init.sh failure on OS/2, KO Myung-Hun, 2017/10/07
- Re: test-init.sh failure on OS/2, Bruno Haible, 2017/10/07
- Re: [PATCH] wcwidth: check a macro version of wcwidth () as well, Bruno Haible, 2017/10/07
- Re: [PATCH] wcwidth: check a macro version of wcwidth () as well, KO Myung-Hun, 2017/10/07
- Re: [PATCH] wcwidth: check a macro version of wcwidth () as well,
Eric Blake <=
- Re: [PATCH] wcwidth: check a macro version of wcwidth () as well, Bruno Haible, 2017/10/09