Re: Out of bounds va_arg access in rpl_fcntl

[Frank Busse]

Hi,


On Thu, 06 Sep 2018 11:26:55 +0200
Bruno Haible <address@hidden> wrote:

>> 2018-09-05  Bruno Haible  <address@hidden>
>> 
>>      fcntl: Don't access nonexistent optional argument.
>>      Reported by Frank Busse <address@hidden> in
>>      <https://lists.gnu.org/archive/html/bug-gnulib/2018-09/msg00018.html>.
>>      * lib/fcntl.c (rpl_fcntl): For actions that don't take an argument,
>>      don't consume an argument. For actions that take an 'int' argument,
>>      consume an 'int' argument.  
> 
> Tested on
>   glibc with Linux kernels before 2.6.24, Mac OS X 10.5,
>   FreeBSD, NetBSD, OpenBSD,
>   AIX 7.1, HP-UX 11, IRIX 6.5, Solaris 11,
>   Cygwin, mingw
> and pushed.

I re-ran KLEE with the affected coreutils and it hasn't found an error
with this patch. Thanks for fixing it and the effort to compile that
huge list of flags.

Btw. KLEE is basically an LLVM interpreter and not a static analysis
tool.


Kind regards,

Frank