Re: __builtin_expect used in regex

[Bruno Haible]

Hi Arnold,

> Nelson, please chime in with a list of the system + compiler combinations
> where gawk needs this patch.

Basically, all platforms with a non-GCC compiler will need this patch.
Think of Solaris cc, HP-UX cc, native Windows with MSVC...

> As I mentioned, this is really a gnulib
> issue and thus I'm reporting it there.

No, it is not an issue in gnulib. In gnulib, the module 'regex' depends
on the module 'builtin-expect' (with the appropriate condition), and this
latter module guarantees that __builtin_expect is defined also on non-GCC
compilers.

The issue is with gawk's use of gnulib: it does not use gnulib-tool and
instead relies on (error-prone) manual sync from source files from gnulib.

Bruno