Re: [PATCH] Printf unsigned ints with %u in gen-uni-tables.c

[Bruno Haible]

Hi Nathan,

> From 1b8a4f9a58453ca592ee4fa638abaa3fba080a1b Mon Sep 17 00:00:00 2001
> From: Nathan Mills <address@hidden>
> Date: Sat, 16 Feb 2019 22:53:09 -0800
> Subject: [PATCH] Printf unsigned ints with %u in gen-uni-tables.c
> Cppcheck gives warnings about gen-uni-tables.c where unsigned ints are
> printf'd with %d where %u should be used instead. This patch fixes 25 of
> these warnings in gen-uni-tables.c.These warnings are pasted below. Below
> that, I have pasted the patch.

The patch looks good. But does it fix all the issues? I mean, in

      fprintf (stream, "#define header_%u %d\n", i,
               ((uint32_t *) t.result)[i]);

there is the issue also with the second argument.

Bruno