bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib-tool.py: Use absolute imports consistently.


From: Bruno Haible
Subject: Re: gnulib-tool.py: Use absolute imports consistently.
Date: Tue, 23 Apr 2024 17:37:31 +0200

Hi Collin,

> > OK, patch welcome. I assume that when Dmitry used this style of assignments,
> > the Python 2.7 / 3.0 imports were not so well developed as they are today.
> 
> Here is a patch that removes all the module-specific variables and
> imports the functions directly.

The patch looks good.

> I ran all the tests quickly with Python 3.7 and 3.12 just to double
> check that I didn't break anything in the process. PyCharm has good
> warnings for missing or unused imports so I used that too.

I also checked the effect on the warnings in Eclipse: No new warnings,
and 1 existing "unused import" warning is fixed.

The patch is OK to push.

Bruno






reply via email to

[Prev in Thread] Current Thread [Next in Thread]