bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[COMMITTED] GDL2 EOQualifier fixes


From: David Ayers
Subject: [COMMITTED] GDL2 EOQualifier fixes
Date: Thu, 13 Feb 2003 12:44:09 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021212

Hello everyone,

after some final cleanups, some added documentation and on or two fixes, I've finally commited the following:

(Please also note the fact that evaluteWithObject: of EOKeyComparisonQualifier and EOKeyValueQualifier now first attempt to actually use the qualifers selector before falling back to the isEqual:, compare:, ... mechanisms.)

       * EOControl/EOAndQualifier.m: Added documentation.
       ([EOAndQualifier +qualifierWithQualifiers:]),
       ([EOAndQualifier -initWithQualifiers:]): Synchronize implementation.
       ([EOAndQualifier -initWithQualifierArray:]): Change ASSIGN to
       ASSIGNCOPY when setting qualifier array (insuring immutability).
       ([EOAndQualifier -copyWithZone:]): remove (use implementation from
       superclass).

       * EOControl/EOKeyComparisonQualifier.m: Added documentation.
       ([EOKeyComparisonQualifier
       +qualifierWithLeftKey:operatorSelector:rightKey:]): Use
       AUTORELEASE() instead of -autorelease.
       ([EOKeyComparisonQualifier
       -initWithLeftKey:operatorSelector:rightKey:]): Use ASSIGNCOPY
       instead of ASSIGN to insure immutable keys.  Added comment about
       possible selector assertion.
       ([EOKeyComparisonQualifier -copyWithZone:]): remove (use
       implementation from superclass).
       ([EOKeyComparisonQualifier -evaluateWithObject:]): Try to call the
       receivers selector before attempting to fallback on other
       mechanisms to evaluate the object. Adjusted local variable names
       and fixed fallback Equal, NotEqual and Contains comparisons.
       ([EOKeyComparisonQualifier -description]): Fall back to
       NSStringFromSelector() if +stringForOperatorSelector returns nil.

       * EOControl/EOKeyValueQualifier.m: Added documentation
([EOKeyValueQualifier +qualifierWithKey:operatorSelector:value:]): Use
       AUTORELEASE() instead of -autorelease.
       ([EOKeyValueQualifier -initWithKey:operatorSelector:value:]): Use
       ASSIGNCOPY instead of ASSIGN to insure immutable key.  Added
       comment about possible selector assertion.
       ([EOKeyValueQualifier -copyWithZone:]): remove (use implementation
       from superclass).
       ([EOKeyValueQualifier -evaluateWithObject:]): Try to call the
       receivers selector before attempting to fallback on other
       mechanisms to evaluate the object. Adjusted local variable names
       and fixed fallback Equal, NotEqual and Contains comparisons.
       ([EOKeyValueQualifier -description]): Fall back to
       NSStringFromSelector() if +stringForOperatorSelector returns nil.

       * EOControl/EONotQualifier.m: Added documentation.
       ([EONotQualifier -copyWithZone:]): remove (use implementation from
       superclass).
       ([EONotQualifier -evaluateWithObject:]): Implemented.

       * EOControl/EOOrQualifier.m: Added documentation.
       ([EOOrQualifier +qualifierWithQualifiers:]),
       ([EOORQualifier -initWithQualifiers:]): Synchronize implementation.
       ([EOOrQualifier -copyWithZone:]): remove (use implementation from
       superclass).
       ([EOOrQualifier -evaluateWithObject:]): Corrected implementation.

       * EOControl/EOQualifier.m: Added documentation
       ([EOQualifier +initialize]), (getKey()): Replace autorelease with
       AUTORELEASE().
       ([EOQualifier -copyWithZone:]):  RETAIN() instead of NSCopyObject().
       ([EOQualifier +variableWithKey:]): Corrected implementation.

Cheers,
Dave






reply via email to

[Prev in Thread] Current Thread [Next in Thread]