Re: ANN: GNUstep base/make Version 1.7.4

[Yen-Ju Chen]

> From: Adam Fedor <fedor@doc.com>
> To: "Yen-Ju Chen" <yjchenx@hotmail.com>
> CC: Bug GNUstep <bug-gnustep@gnu.org>
> Subject: Re: ANN: GNUstep base/make Version 1.7.4
> Date: Tue, 16 Sep 2003 21:36:06 -0600
>
>
> On Tuesday, September 16, 2003, at 10:14 AM, Yen-Ju Chen wrote:
>
> > I hope this bug can be fixed since it is quite simple:
> >
> > [bug #5254] "cvtenc -EscapeIn yes" use wront encoding
> > Submitted By: yjchen    group: GNUstep
>
> Shouldn't the patch rather be this (assuming if you want to escape the 
> input it must be in Unicode format [ is that correct?]):

 It doesn't work because in your patch,
 the iEnc is set to NSUnicodeStringEncoding for "-EscapeIn Yes" case,
 and this iEnc is immediately used to read the file,
 which is in ASCII (local) encoding or Unicode encoding.
 For the ASCII encoding, it fails.
 The input file could be in Unicode encoding or local encoding (ASCII 
actually).
 That's the reason the if... in your patch is checking.

 So for "-EscapeIn Yes" and input file is in local encoding (ASCII),
 it should read the file in iEnc encoding, convert \uXXXX into Unicode in 
NSString,
 then write this NSString using the iEnc again (line 234-238)
 since the iEnc is the encoding of user environment.

 For "-EscapeIn Yes" and input file is Unicode,
 using iEnc is still correct because input and output are all Unicode 
encoding (iEnc).

 Hope my explanation is clear for you.

 Yen-Ju

> << cvtenc.patch >>

_________________________________________________________________
Use custom emotions -- try MSN Messenger 6.0! 
http://www.msnmessenger-download.com/tracking/reach_emoticon