Re: [PATCH] NSCalendar date patch

[Richard Frith-Macdonald]

On 25 Feb 2004, at 13:22, Wim Oudshoorn wrote:
> Solution
> --------
> The following patch will solve all these problems EXCEPT
> the first.  It will introduce a strcpy of the format string
> which is in most cases not necessary, but I do not
> think this is a critical problem.
> Also the %c %X %x conversion are not really efficient.
> And it bothers me a little that the buffer overrun is
> still there, but getting rid of that requires siginificantly
> more work.

Frankly, IMO, the code needs a complete rewrite.

1. The potential (though unlikey) overflow should be fixed.
2. the method should support unicode

So, while I don't object to the patch as such, I'd like it much
better if it created a mutable data object and appended unichars to
it then converted the result to a string when done.