bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #4598] filesystemRepresentation on Win32 is DANGEROUS as implemen


From: Jeremy Bettis
Subject: [patch #4598] filesystemRepresentation on Win32 is DANGEROUS as implemented
Date: Fri, 4 Nov 2005 21:01:21 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7

URL:
  <http://savannah.gnu.org/patch/?func=detailitem&item_id=4598>

                 Summary: filesystemRepresentation on Win32 is DANGEROUS as
implemented
                 Project: GNUstep
            Submitted by: jeremybettis
            Submitted on: Fri 11/04/05 at 21:01
                Category: Foundation
                Priority: 9 - Immediate
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open

    _______________________________________________________

Details:

*) filesystemRepresentation is declared as returning char* when it actually
returns unichar*
*) Even gnustep-base itself has uses of filesystemRepresentation that are not
expecting unichars.
*) Unicode is NOT the native filesystem encoding for the Win32 API.  Win32
actually has 2 "native" encodings.

This patch resolves all of these issues.
new method -unicodeFilesystemRepresentation
fixed all win32 uses of filesystemRepresentation to use the new
unicodeFilesystemRepresentation
fixed all of the occurances of a unicode string being passed to a ANSI api
call






    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 11/04/05 at 21:01  Name: filesystemrep-unicode.patch.txt  Size:
32.36KB   By: jeremybettis

<http://savannah.gnu.org/patch/download.php?item_id=4598&item_file_id=5435>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?func=detailitem&item_id=4598>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]