[bug #30724] To determine FixPitch trait we need to ask for spacing infomation.

[Derek Fawcus]

URL:
  <http://savannah.gnu.org/bugs/?30724>

                 Summary: To determine FixPitch trait we need to ask for
spacing infomation.
                 Project: GNUstep
            Submitted by: dfawcus
            Submitted on: Tue 10 Aug 2010 08:09:11 AM GMT
                Category: Backend
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

The Xft fontconfig enumerator (the the cairo one based on it) share a bug in
that the FixPitch trait is not correctly calculated.  This is because it
depends upon the presense of the FC_SPACING attribute,  and only those
attributes explicitly requested are included in the results from the search.

The below patch is against the refactored version of the code I've not yet
shown,  however it is obvious how to manually apply it to both the Xft and
Cairo code.

Author: Derek Fawcus <dfawcus@employees.org>
Date:   Thu Aug 5 22:18:09 2010 +0100

    To determine FixPitch trait we need to ask for spacing infomation.

diff --git a/Source/x11/FcFontEnumerator.m b/Source/x11/FcFontEnumerator.m
index 9a76bea..9bdd49f 100644
--- a/Source/x11/FcFontEnumerator.m
+++ b/Source/x11/FcFontEnumerator.m
@@ -144,7 +144,7 @@ static NSArray *faFromFc(FcPattern *pat)
   NSMutableArray *fc_allFontNames = [[NSMutableArray alloc] init];

   FcPattern *pat = FcPatternCreate();
-  FcObjectSet *os = FcObjectSetBuild(FC_FAMILY, FC_SLANT, FC_WEIGHT, NULL);
+  FcObjectSet *os = FcObjectSetBuild(FC_FAMILY, FC_SLANT, FC_WEIGHT,
FC_SPACING, NULL);
   FcFontSet *fs = FcFontList(0, pat, os);

   FcPatternDestroy(pat);






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30724>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/