Please review kongoni's icecat build settings

[A.J. Venter]

Hi All,
I'm new to the list, but I'm writing with a fairly important reason :)
I'm the lead developer of the Kongoni GNU/Linux distribution, as of
our next release we'll be switching to Icecat as our default browser
since we are a fully-free distribution (with this release we will also
be ready to apply to be listed on the GNU site as such).

I don't think I need to explain why we chose Icecat over firefox
despite the fact that our upstream system (slackware) is a permitted
distributor - everyone here shares the same feelings about it. In
order to get the first set of packages out (actually Kongoni is a
ports based system so technically all we ship is a build script) I
used a modified version of the slackbuild script that slackware uses
to build mozilla-firefox.

This builds just fine apart from a one or two minor adjustments I had
to make to the configuration parameters. I do have one concern
however, namely that with the parameters as originally written for
firefox, I may actually be reactivating some things that icecat is
specifically meant to deactivate. So I was hoping you could look over
our configuration parameters and make any constructive suggestions for
improvements, which can then go into the next release of the port in
good time for the next distro release.

The current build part of the script looks like this:

NUMJOBS=${NUMJOBS:-" -j7 "}
# Try to be gentle to the compiler, no optimizations:
if [ "$ARCH" = "i486" ]; then
  SLKCFLAGS="-O"
  LIBDIRSUFFIX=""
elif [ "$ARCH" = "s390" ]; then
  SLKCFLAGS="-O"
  LIBDIRSUFFIX=""
elif [ "$ARCH" = "x86_64" ]; then
  SLKCFLAGS="-O -fPIC"
  LIBDIRSUFFIX="64"
elif [ "$ARCH" = "arm" ]; then
  SLKCFLAGS="-O2 -march=armv4 -mtune=xscale"
  LIBDIRSUFFIX=""
elif [ "$ARCH" = "armel" ]; then
  SLKCFLAGS="-O2 -march=armv4t"
  LIBDIRSUFFIX=""
fi

export BUILD_OFFICIAL="1" &&
export MOZ_PHOENIX="1" &&
export CFLAGS="$SLKCFLAGS" &&
export CXXFLAGS="$SLKCFLAGS" &&
./configure \
  --prefix=/usr \
  --libdir=/usr/lib${LIBDIRSUFFIX} \
  --with-default-mozilla-five-home=/usr/lib${LIBDIRSUFFIX}/icecat-$SRVERSION \
  --with-system-zlib \
  --enable-application=browser \
  --enable-default-toolkit=cairo-gtk2 \
  --enable-crypto \
  --enable-svg \
  --enable-canvas \
  --enable-xft \
  --enable-xinerama \
  --enable-optimize \
  --enable-reorder \
  --enable-strip \
  --enable-system-cairo \
  --enable-cpp-rtti \
  --enable-single-profile \
  --disable-ldap \
  --disable-accessibility \
  --disable-debug \
  --disable-tests \
  --disable-logging \
  --disable-pedantic \
  --disable-installer \
  --disable-mailnews \
  --disable-composer \
  --disable-profilesharing
  # Complains about missing APNG support in Slackware's libpng:
  #--with-system-png \

make MOZ_MAKE_FLAGS="$NUMJOBS" || exit 1


Thanks in advance
A.J. Venter