Re: [bug-grep] length of dec. representation of a number

[Stepan Kasal]

Hi Julian,

On Thu, Feb 24, 2005 at 03:57:34PM +0000, Julian Foad wrote:
> > get_nondigit_option (int argc, char *const *argv, int *default_context)
> > {
> >   int opt;
> >-  char buf[sizeof (uintmax_t) * CHAR_BIT + 4];
> >+  char buf[(sizeof(uintmax_t) + 1) / 2 * 5 + 4];  /* log_10(2^16) < 5 */
> 
> If you're optimising the buffer size, there's something else you should do. 
> Here, the result is going to be stored in *default_context, an "int".  
> There's no point in allowing a number as big as "uintmax_t".  [...]

Yes, you are right, we should do
  char buf[INT_BUFSIZE_BOUND(*default_context) + 3];  /* 3 dots when we give up 
*/

Stepan Kasal