Re: [bug-grep] Boyer Moore overflow patch

[Tony Abou-Assaleh]

> >        for (i = 0; i < kwset->mind; ++i)
> > -   delta[(unsigned char) kwset->target[i]] = kwset->mind - (i + 1);
> > +   delta[(unsigned char) kwset->target[i]] =
> > +     MIN(kwset->mind - (i + 1), UCHAR_MAX);
>
> There should be a space after the "MIN".  (This is the style
> recommended by the GNU coding standards.)

If we wish to follow the GNU formatting standards, we could simply run
gindent on all the sources without parameters. Doing this will greatly
simplify writing patches as we no longer have to conform to any
formatting; simply run gindent (with the default configs) before creating
the patch.

Similarly, if one doesn't like the source formatting, they could run
gindent with whatever params they like, edit, then run gindent without
params.

Cheers,

TAA

--------------------------------------------------
Tony Abou-Assaleh
Ph.D. Candidate, Faculty of Computer Science
Dalhousie University, Halifax, NS, Canada, B3H 1W5
Fax:   902-492-1517
Email: address@hidden
WWW:   http://www.cs.dal.ca/~taa/
---------------------[THE END]--------------------