bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/17] dfa, grep: cleanup if-before-free and cast-of-argument


From: Jim Meyering
Subject: Re: [PATCH 05/17] dfa, grep: cleanup if-before-free and cast-of-argument-to-free
Date: Fri, 12 Mar 2010 19:10:06 +0100

Paolo Bonzini wrote:
> * .x-sc_avoid_if_before_free: Remove.
> * .x-sc_cast_of_alloca_return_value: Remove.
> * .x-sc_cast_of_x_alloc_return_value: Remove.
> * .x-sc_cast_of_argument_to_free: Temporarily add src/search.c.
> * cfg.mk (local-checks-to-skip): Remove sc_cast_of_argument_to_free.
> * src/dfa.c (ifree): Remove.
> (dfamust, build_state, transit_state, dfafree): Do not do if-before-free,
> do not cast free argument to ptr_t or char *.
> (freelist): Call free instead of ifree.
> ---
>       The src/search.c exception will go away later in the series.
>
>  .x-sc_avoid_if_before_free         |    2 -
>  .x-sc_cast_of_alloca_return_value  |    1 -
>  .x-sc_cast_of_argument_to_free     |    1 +
>  .x-sc_cast_of_x_alloc_return_value |    1 -
>  cfg.mk                             |    1 -
>  src/dfa.c                          |   93 
> ++++++++++++++----------------------
>  6 files changed, 37 insertions(+), 62 deletions(-)
                    ^^                ^^
Welcome changes!
ACK.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]