Re: [PATCH] build: allow compilation on cygwin

[Jim Meyering]

Eric Blake wrote:
> Gnulib is incompatible with -Wunused-macros.  Addtionally,
> cygwin 1.7.1 coupled with --enable-gcc-warnings tripped on:
>
> grep.c: In function 'print_line_middle':
> grep.c:805: error: array subscript has type 'char' [-Wchar-subscripts]
> grep.c: In function 'main':
> grep.c:1833: error: 'optarg' redeclared without dllimport attribute: previous 
> dllimport ignored [-Wattributes]
> grep.c:1834: error: 'optind' redeclared without dllimport attribute after 
> being referenced with dll linkage
>
> * configure.ac (GNULIB_WARN_FLAGS): Disable -Wunused-macros.
> * src/grep.c (print_line_middle): Use correct type to tolower.
> (main): Drop useless redeclarations.
> * .gitignore: Ignore more built files.

Those all look fine.
The array subscript change appears to be a genuine bug fix.
Thanks.

You're welcome to push that.