bug-grep
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: EGexecute: don't assume buffer ends in a newline

From: Paolo Bonzini
Subject: Re: EGexecute: don't assume buffer ends in a newline
Date: Sun, 15 Aug 2010 19:53:30 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5 
On 05/24/2010 01:06 PM, Paolo Bonzini wrote:

No. You see that and the end of the search loop, there is a
     if (best_match < end)
that I turned into
     if (best_match <= end)
This statement is meant to detect whether a match has been found at all.
So, the initial value of best_match has to be greater than 'end' in
all cases.


Right.  That's violating ISO C's rule for validity of pointers though.
In practice I don't think it matters, but I'd rather get a second
opinion on this patch.


Ping?

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]