Re: suggested fixes for dfa.c

[Jim Meyering]

Jim Meyering wrote:

> Aharon Robbins wrote:
>> Upon comparing grep's dfa.c to the development gawk, I suggest the
>> following fixes.
>>
>> 1. Remove the #ifdef GAWK - upcoming gawk supports \s and \S
>> 2. Move add_utf8_anychar into the MBS_SUPPORT #ifdef.  This latter has
>>    been reported on the list before - I thought it'd been checked in even.
>>    :-)
>
> Thanks for the patch.
>
> However, would you please convert those to two actual commits (in a cloned
> grep working directory), each with its own commit log?  Then you can send
> the output of "git format-patch --stdout -2 -p" and I can simply run

Oops.  The command to use is this: (i.e., no -p):

  git format-patch --stdout -2 > FILE

> "git am EACH_MESSAGE" to apply them without hassling with attribution --
> you'll be listed as the "Author" -- separating them, or writing log messages.
>
> It's a good exercise, and a practice you should encourage
> all gawk contributors to follow, as well.