Re: grep-2.9.69-f91c on OSF/1

[Jim Meyering]

Bruno Haible wrote:

> Jim Meyering wrote:
>> > It comes from tests/Makefile:
>> >
>> > TESTS_ENVIRONMENT = \
>> >   tmp__=$$TMPDIR; test -d "$$tmp__" || tmp__=.; \
>> >   TMPDIR=$$tmp__; export TMPDIR;                \
>> >   export                                        \
>> >   VERSION='$(VERSION)'                          \
>> >   ...
>> >
>> > The syntax "export VAR=VALUE" is not guaranteed by this shell.
>> > Either write "env VAR=VALUE ...", or "VAR=VALUE; export VAR; ..."
>> >
>> > SHELL is defined as
>> > SHELL = /bin/ksh
>> >
>> > $ grep CONFIG_SHELL config.status
>> > SHELL=${CONFIG_SHELL-/bin/ksh}
>> >   $as_echo "running CONFIG_SHELL=/bin/ksh $*" >&6
>> >   CONFIG_SHELL='/bin/ksh'
>> >   export CONFIG_SHELL
>>
>> Hi Bruno,
>>
>> Thanks for the report.
>> Can you work around it by running something like
>> "make CONFIG_SHELL=bash"?
>
> $ make check CONFIG_SHELL=bash
> $ make check SHELL=bash
> $ make check SHELL=/opt/fsw/bin/bash
>
> all fail in the same way.
>
> Even when I change config.status, replacing
>   S["SHELL"]="/bin/ksh"
> by
>   S["SHELL"]="/opt/fsw/bin/bash"
> then tests/Makefile contains
>   SHELL = /opt/fsw/bin/bash
> but "make check" still fails the same way. Apparently only GNU make, not
> OSF/1 'make', considers the SHELL variable from the Makefile.

Then one work-around for those who require to be able to run grep's
"make check" before "make install" on OSF/1 is to use GNU make.
I am inclined to document that, say in README.

>> I would much rather recommend that work-around than pessimize all
>> "make check" rules like that -- and just for a few old, losing systems.
>
> It's a lot of prerequisiste work to have to install bash and GNU make,
> for being able to install GNU grep. Past these two hurdles, all grep
> tests pass and 2 gnulib tests fail (test-exclude2.sh, test-exclude5.sh).
>
>> I'll let others worry about these failures.
>
> Then here's a proposed patch.

Thanks, but my "these failures" comment was referring to mingw and MSYS
test failures.

> 2011-11-11  Bruno Haible  <address@hidden>
>
>       Fix test suite execution failure on OSF/1 5.1.
>       * tests/Makefile.am (TESTS_ENVIRONMENT): Use only the portable form of
>       the 'export' shell built-in.

Thanks, but I'd like to find a way to resolve this that does not involve
repeating every envvar name.  At worst, I will simply document the
requirement that GNU make be used by those who require to run "make check".

> diff -r -u multibuild-1488/linux/grep-2.9.69-f91c/tests/Makefile.am 
> grep-2.9.69-f91c/tests/Makefile.am
> --- multibuild-1488/linux/grep-2.9.69-f91c/tests/Makefile.am  2011-10-10 
> 14:41:27.000000000 +0200
> +++ grep-2.9.69-f91c/tests/Makefile.am        2011-11-11 22:45:13.000000000 
> +0100
> @@ -102,30 +102,29 @@
>  # http://udrepper.livejournal.com/11429.html
>  MALLOC_PERTURB_ = 1
>
...
> +  TMPDIR=$$tmp__; export TMPDIR;                                          \
> +  VERSION='$(VERSION)'; export VERSION;                                      
>      \
> +  LOCALE_FR='$(LOCALE_FR)'; export LOCALE_FR;                                
>      \
> +  LOCALE_FR_UTF8='$(LOCALE_FR_UTF8)'; export LOCALE_FR_UTF8;              \
> +  AWK=$(AWK); export AWK;                                                 \
> +  GREP_OPTIONS=''; export GREP_OPTIONS;                                      
>      \
> +  LC_ALL=C; export LC_ALL;                                                \
> +  abs_top_builddir='$(abs_top_builddir)'; export abs_top_builddir;        \
> +  abs_top_srcdir='$(abs_top_srcdir)'; export abs_top_srcdir;              \
> +  abs_srcdir='$(abs_srcdir)'; export abs_srcdir;                          \
> +  built_programs='grep egrep fgrep'; export built_programs;               \
> +  srcdir='$(srcdir)'; export srcdir;                                      \
> +  top_srcdir='$(top_srcdir)'; export top_srcdir;                          \
> +  CC='$(CC)'; export CC;                                                  \
> +  GREP_TEST_NAME=`echo $$tst|sed 's,^\./,,;s,/,-,g'`; export GREP_TEST_NAME; 
> \
> +  MAKE=$(MAKE); export MAKE;                                              \
> +  MALLOC_PERTURB_=$(MALLOC_PERTURB_); export MALLOC_PERTURB_;                
>      \
> +  PACKAGE_BUGREPORT='$(PACKAGE_BUGREPORT)'; export PACKAGE_BUGREPORT;        
>      \
> +  PACKAGE_VERSION=$(PACKAGE_VERSION); export PACKAGE_VERSION;                
>      \
> +  PERL='$(PERL)'; export PERL;                                               
>      \
> +  SHELL='$(SHELL)'; export SHELL;                                         \
>    PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
>    ; 9>&2