Re: grep-dir test

[Paolo Bonzini]

On 12/20/2011 06:39 PM, Eli Zaretskii wrote:
> > >     echo foo | grep -f empty-directory/
> >
> > This should be a hard failure.  Asking grep to open a directory and
> > search for patterns in it is wrong.
>
> Well, I agree.  But the test suite doesn't.

Yes, that's why it's an expected failure.

> > If you get XPASSes from the last two on Windows, that's good. :)
>
> Indeed, I do.
>
> So it would make sense not to flag it as XPASS, I think.

Yeah, you could add a configure run-time test that opens a directory and 
an Automake conditional.  If the test fails, the Automake conditional 
should _not_ mark the tests as expected failures.

Paolo