Re: MS-Windows build of Grep [2/4]

[Paolo Bonzini]

On Thu, Dec 29, 2011 at 23:15, Paul Eggert <address@hidden> wrote:
> On 12/29/11 13:56, Paolo Bonzini wrote:
>> there is no reason to split files
>
> Yes there is: separation of concerns.
> The Microsoft stuff is a separate porting layer,
> like gnulib, and like gnulib it shouldn't
> be in the same source directory as the main code.

It is a common API used by both POSIX and Windows targets.  It can go
in lib/ rather than src/, but I disagree about splitting it in POSIX
and Windows files as long as the code for Windows is a superset of the
POSIX code.  In fact, it is possible to factor the #ifdefs within each
function (without a single #else); it doesn't make much sense as long
as it stays in src/main.c, but it does if the code moves to
lib/colorize.[ch].

Please hold the patches a bit, let's first split out the colorize code
and then decide how to handle it.

Paolo